We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The code has mixed style between TypeOf something === function and function === TypeOf something.
TypeOf something === function
function === TypeOf something
https://github.com/1602/compound/blob/master/lib/controller-extensions.js#L137 https://github.com/1602/compound/blob/master/lib/controller-extensions.js#L304 https://github.com/1602/compound/blob/master/lib/controller-extensions.js#L307 https://github.com/1602/compound/blob/master/lib/compound.js#L167 https://github.com/1602/compound/blob/master/lib/compound.js#L257 https://github.com/1602/compound/blob/master/lib/compound.js#L264
Most are if (typeof VAR === 'function') { style. So it wouldn't hurt to stick to it.
if (typeof VAR === 'function') {
The text was updated successfully, but these errors were encountered:
@Anachron You can freely open a pull request with your preferred style.
Sorry, something went wrong.
Should be 'typename' === typeof variablename
On 2 June 2014 14:22, Fodi69 [email protected] wrote:
@Anachron https://github.com/Anachron You can freely open a pull request with your preferred style. — Reply to this email directly or view it on GitHub #627 (comment).
@Anachron https://github.com/Anachron You can freely open a pull request with your preferred style.
— Reply to this email directly or view it on GitHub #627 (comment).
No branches or pull requests
The code has mixed style between
TypeOf something === function
andfunction === TypeOf something
.https://github.com/1602/compound/blob/master/lib/controller-extensions.js#L137
https://github.com/1602/compound/blob/master/lib/controller-extensions.js#L304
https://github.com/1602/compound/blob/master/lib/controller-extensions.js#L307
https://github.com/1602/compound/blob/master/lib/compound.js#L167
https://github.com/1602/compound/blob/master/lib/compound.js#L257
https://github.com/1602/compound/blob/master/lib/compound.js#L264
Most are
if (typeof VAR === 'function') {
style. So it wouldn't hurt to stick to it.The text was updated successfully, but these errors were encountered: