Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts between AWS SDK in this plugin and others #822

Open
1 task done
lakrisgubben opened this issue Oct 25, 2024 · 0 comments
Open
1 task done

Conflicts between AWS SDK in this plugin and others #822

lakrisgubben opened this issue Oct 25, 2024 · 0 comments
Labels
help wanted Extra attention is needed needs:engineering This requires engineering to resolve.
Milestone

Comments

@lakrisgubben
Copy link

Describe your question

Hey y'all,

first of all thanks for a great plugin! :)

Since Amazon Polly was added as a text-to-speech provider this plugin can conflict with other plugins (or other parts of wp-apps) that also uses the AWS SDK. In general this wouldn't be a big problem as long as both places that loaded the SDK where using a somewhat similar version. But since Classifai removes all services from the AWS SDK except for Polly this can lead to issues such as missing methods in the SDK.

I realize that loading all of the AWS SDK will make the plugin-zip really large, so I was wondering if maybe you could use something like https://github.com/coenjacobs/mozart to namespace the dependencies brought in via composer? Or if you've got any better ideas to solve the conflict.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@lakrisgubben lakrisgubben added the type:question Further information is requested. label Oct 25, 2024
@jeffpaul jeffpaul added this to the 3.2.0 milestone Oct 25, 2024
@jeffpaul jeffpaul added needs:engineering This requires engineering to resolve. help wanted Extra attention is needed and removed type:question Further information is requested. labels Oct 25, 2024
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs:engineering This requires engineering to resolve.
Projects
Status: To Do
Development

No branches or pull requests

2 participants