Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global.config not being used everywhere #1

Open
mmmjung opened this issue Nov 23, 2019 · 2 comments
Open

global.config not being used everywhere #1

mmmjung opened this issue Nov 23, 2019 · 2 comments

Comments

@mmmjung
Copy link

mmmjung commented Nov 23, 2019

Line that copies which dataset (task) we use is commented:

#args.task_name = configs_dict.get("dataset")

It means that if you clone the repo and run:

python finetune_dataset.py
python aug_dataset.py

you will get an error, because one of the commands runs for rt-polarity and the other for subj dataset.

Besides this, maybe some of the other parameters should be copied from global.config?

@1024er
Copy link
Owner

1024er commented Mar 23, 2020

Sorry for not being able to respond in time due to busy work.

I have switch the code to a new branch, which is more neat and easy to follow.

@mmmjung
Copy link
Author

mmmjung commented Mar 23, 2020

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants