From a84627197565b0caf378495e4ee672d7430669ac Mon Sep 17 00:00:00 2001 From: Kaustubh Kumar Date: Wed, 4 Oct 2023 15:22:48 +0530 Subject: [PATCH 1/2] fix: duplicate error code --- packages/hms-video-web/src/error/ErrorCodes.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/hms-video-web/src/error/ErrorCodes.ts b/packages/hms-video-web/src/error/ErrorCodes.ts index b1cfd67bc7..89ef0bdb6d 100644 --- a/packages/hms-video-web/src/error/ErrorCodes.ts +++ b/packages/hms-video-web/src/error/ErrorCodes.ts @@ -45,7 +45,7 @@ export const ErrorCodes = { DEVICE_IN_USE: 3003, // Lost access to capture device midway - {device_type} - DEVICE_LOST_MIDWAY: 3008, + DEVICE_LOST_MIDWAY: 3004, // There is no media to return. Please select either video or audio or both. NOTHING_TO_RETURN: 3005, From f0f9bf9400f02c249be5d065446a4a64ba6963aa Mon Sep 17 00:00:00 2001 From: Kaustubh Kumar Date: Wed, 4 Oct 2023 17:20:23 +0530 Subject: [PATCH 2/2] fix: add prompt for mweb landscape mode --- packages/roomkit-react/src/Prebuilt/App.tsx | 2 ++ .../{MwebLandscapePrompt.jsx => MwebLandscapePrompt.tsx} | 1 + packages/roomkit-react/src/Prebuilt/components/RaiseHand.jsx | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) rename packages/roomkit-react/src/Prebuilt/components/{MwebLandscapePrompt.jsx => MwebLandscapePrompt.tsx} (98%) diff --git a/packages/roomkit-react/src/Prebuilt/App.tsx b/packages/roomkit-react/src/Prebuilt/App.tsx index 6f600aa36e..d4e07ebd52 100644 --- a/packages/roomkit-react/src/Prebuilt/App.tsx +++ b/packages/roomkit-react/src/Prebuilt/App.tsx @@ -22,6 +22,7 @@ import FullPageProgress from './components/FullPageProgress'; import { Init } from './components/init/Init'; // @ts-ignore: No implicit Any import { KeyboardHandler } from './components/Input/KeyboardInputManager'; +import { MwebLandscapePrompt } from './components/MwebLandscapePrompt'; // @ts-ignore: No implicit Any import { Notifications } from './components/Notifications'; import { HeadlessEndRoomListener } from './components/Notifications/HeadlessEndRoomListener'; @@ -350,6 +351,7 @@ function AppRoutes({ <> + {!isNotificationsDisabled && } diff --git a/packages/roomkit-react/src/Prebuilt/components/MwebLandscapePrompt.jsx b/packages/roomkit-react/src/Prebuilt/components/MwebLandscapePrompt.tsx similarity index 98% rename from packages/roomkit-react/src/Prebuilt/components/MwebLandscapePrompt.jsx rename to packages/roomkit-react/src/Prebuilt/components/MwebLandscapePrompt.tsx index df150c2cf4..460a7379ab 100644 --- a/packages/roomkit-react/src/Prebuilt/components/MwebLandscapePrompt.jsx +++ b/packages/roomkit-react/src/Prebuilt/components/MwebLandscapePrompt.tsx @@ -5,6 +5,7 @@ import { Box, Flex } from '../../Layout'; import { Dialog } from '../../Modal'; import { Text } from '../../Text'; import { PrebuiltDialogPortal } from './PrebuiltDialogPortal'; +// @ts-ignore: No implicit Any import { isAndroid, isIOS } from '../common/constants'; export const MwebLandscapePrompt = () => { diff --git a/packages/roomkit-react/src/Prebuilt/components/RaiseHand.jsx b/packages/roomkit-react/src/Prebuilt/components/RaiseHand.jsx index e3d44041c2..269199f5cf 100644 --- a/packages/roomkit-react/src/Prebuilt/components/RaiseHand.jsx +++ b/packages/roomkit-react/src/Prebuilt/components/RaiseHand.jsx @@ -9,7 +9,7 @@ export const RaiseHand = () => { const { isHandRaised, toggleHandRaise } = useMyMetadata(); return ( - await toggleHandRaise()}> + await toggleHandRaise()}>