Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal library "visibility_detector": to latest version 🐛 #1712

Closed
mobile-development-group-com opened this issue Feb 14, 2024 · 8 comments · Fixed by #1735
Closed
Assignees
Labels

Comments

@mobile-development-group-com

Description

Latest update to version 0.4.0+2 is almost a year old and includes a bug fix for "Fix a bug for updates to render objects that have not been laid out yet". Please update to the latest version.

100ms Flutter Version

1.9.9

Steps to reproduce

Add the following to pubspec:

visibility_detector: ^0.4.0+2

#100 ms live
hms_room_kit: ^1.0.12
hmssdk_flutter: ^1.9.9

Expected results

App should be able to compile.

Code example, screenshot, or link to a repository

.

Logs

No response

Flutter Doctor output

[✓] Flutter (Channel stable, 3.16.9, on macOS 14.2.1 23C71 darwin-arm64, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.1)
[✓] VS Code (version 1.85.1)
[✓] Connected device (4 available)
[✓] Network resources

• No issues found!

Copy link

Hello! Thank you for filing an issue.

Please include relevant logs or detailed description for faster resolutions.

We really appreciate your contribution!

@Gnpiwano
Copy link

No logs or detailed subscription required just open a new flutter project and include above dependencies and the project won't compile.

@ygit
Copy link
Member

ygit commented Feb 16, 2024

@Gnpiwano @mobile-development-group-com We tested this by creating a new Flutter project. The Flutter version used was 3.16.9. We were able to compile the project successfully.
Can you share a minimal project where this issue is reproducible?

@Gnpiwano
Copy link

Hmm if i create a new flutter project (flutter version: Flutter 3.16.9 • channel stable, Dart 3.2.6 • DevTools 2.28.5) and add the following lines in my pubspec:

hms_room_kit: ^1.0.12
hmssdk_flutter: ^1.9.9
visibility_detector: ^0.4.0+2

I get the following error:
Because every version of hms_room_kit depends on focus_detector ^2.0.1 which depends on visibility_detector ^0.2.2, every version of hms_room_kit requires visibility_detector ^0.2.2.
So, because test_100ms depends on both hms_room_kit ^1.0.12 and visibility_detector ^0.4.0+2, version solving failed.

You can try the following suggestion to make the pubspec resolve:

  • Consider downgrading your constraint on visibility_detector: flutter pub add visibility_detector:^0.2.2

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@ygit
Copy link
Member

ygit commented Mar 18, 2024

hey @mobile-development-group-com
We have updated the focus_detector package which uses the latest visibility_detector version.
For now, it's kept on a branch, you can refer to this branch & update the hmssdk_flutter package.
To test it, in your pubspec.yaml file make the following change -

hmssdk_flutter:
    git:
      url: https://github.com/100mslive/100ms-flutter.git
      ref: FLUT-277 # branch name
      path: packages/hmssdk_flutter

@ygit ygit self-assigned this Mar 18, 2024
@ygit
Copy link
Member

ygit commented Mar 22, 2024

hey @mobile-development-group-com @Gnpiwano
Were you able to try out the solution I have mentioned above?

@ygit ygit added Stale and removed enhancement New feature or request labels Mar 28, 2024
Copy link

github-actions bot commented Apr 3, 2024

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants