Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with Sander #3

Closed
wants to merge 4 commits into from
Closed

Merge with Sander #3

wants to merge 4 commits into from

Conversation

0xfabi
Copy link
Owner

@0xfabi 0xfabi commented Jun 8, 2018

No description provided.

@svdhoog
Copy link

svdhoog commented Jun 8, 2018

The changes to config.yaml and plot_config.yaml in my commit to the master are in order to have more examples. Perhaps we should split this up into two example config folders:

1 config files for tests (the ones shown on the readme.rst page)

2 config files for more complete set of examples -- this is part of the testing of all combinations in issue svdhoog#20:
svdhoog#20

Also the results plots for those two sets should be distinguished then:

1 results for tests (like it is now in this repo)

2 results for more complete set of examples

@0xfabi
Copy link
Owner Author

0xfabi commented Jun 8, 2018

I could create a config_full_examples folder which contains your new yaml files.
For developing purposes small config files are better because it is much faster.

@svdhoog
Copy link

svdhoog commented Jun 8, 2018

Agreed. The above conflicts would then still need to be resolved on my end, I suspect?
Since I overwrote the original ones?

@svdhoog
Copy link

svdhoog commented Jun 8, 2018

I'll try first to replace the results folder in my fork with the new generic names. Then see if the conflict have disappeared.

@0xfabi
Copy link
Owner Author

0xfabi commented Jun 8, 2018

Please just do nothing.
I will merge everything by myself.

For the config files I will create a new folder, ok (config_full_examples)?

@0xfabi 0xfabi closed this Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants