Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argent account class should be predeclared #629

Open
FabijanC opened this issue Oct 18, 2024 · 0 comments · May be fixed by #658
Open

Argent account class should be predeclared #629

FabijanC opened this issue Oct 18, 2024 · 0 comments · May be fixed by #658
Assignees
Labels
enhancement New feature or request

Comments

@FabijanC
Copy link
Contributor

FabijanC commented Oct 18, 2024

Current solution

Currently users rely on forking to achieve this, as described in the docs.
That's why we thought it's sufficient to mark #171 as resolved.

Request

But it seems users want to be able to do this without forking, as requested on Slack.

Questions

  1. Should we predeclare just the latest version and update it when needed? Or do we keep on accumulating these classes, as new Argent account versions appear? Because in the first case, it might constitute a breaking change if a predeclared class suddenly disappears (i.e. is replaced). It might not be a breaking change if we warn the users in the docs that they should not rely on a predeclared Argent account class to be always present at the same hash value.

  2. What would be the startup time impact of this? Can we use the existing benchmarking scripts for this or do we need a new one?

@FabijanC FabijanC added the enhancement New feature or request label Oct 18, 2024
@FabijanC FabijanC self-assigned this Dec 4, 2024
@FabijanC FabijanC linked a pull request Dec 4, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

1 participant