Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execution error on estimation and simulation should return TRANSACTION_EXECUTION_ERROR #620

Closed
FabijanC opened this issue Oct 4, 2024 · 0 comments · Fixed by #627
Closed

Execution error on estimation and simulation should return TRANSACTION_EXECUTION_ERROR #620

FabijanC opened this issue Oct 4, 2024 · 0 comments · Fixed by #627
Assignees
@FabijanC
Labels
bug Something isn't working

Comments

@FabijanC
Copy link
Contributor

FabijanC commented Oct 4, 2024 •
edited
Loading

We are returning ContractError (code=40), but should be returning TransactionExecutionError (code=41).

The same is in the upcoming RPC v0.8.0 (#613).
@FabijanC FabijanC added the bug Something isn't working label Oct 4, 2024
@FabijanC FabijanC mentioned this issue Oct 11, 2024
Merged
10 tasks
@FabijanC FabijanC self-assigned this Oct 17, 2024
@FabijanC FabijanC linked a pull request Oct 17, 2024 that will close this issue
Rpc 0.8.0 errors #627
Merged
10 tasks
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in starknet-devnet-rs Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FabijanC FabijanC

Labels
bug Something isn't working
Projects
starknet-devnet-rs
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rpc 0.8.0 errors 0xSpaceShard/starknet-devnet-rs
1 participant
@FabijanC