Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instances of SN_GOERLI chain ID need to be replaced with SN_SEPOLIA #389

Closed
FabijanC opened this issue Mar 19, 2024 · 1 comment · Fixed by #396
Closed

Instances of SN_GOERLI chain ID need to be replaced with SN_SEPOLIA #389

FabijanC opened this issue Mar 19, 2024 · 1 comment · Fixed by #396
Assignees
@FabijanC
Labels
bug Something isn't working enhancement New feature or request

Comments

@FabijanC
Copy link
Contributor

FabijanC commented Mar 19, 2024 •
edited
Loading

Currently we depend on starknet-rs' implementation of ChainId, which doesn't have this updated yet. We could incite the update of starknet-rs by contacting its maintainer, or we could implement our own ChainId abstraction.

Also, in the Display implementation, the needed change is independent of starknet-rs.

Labeling as enhancement and as bug since Goerli is no longer supported.
@FabijanC FabijanC added bug Something isn't working enhancement New feature or request labels Mar 19, 2024
@tkumor3 tkumor3 mentioned this issue Mar 22, 2024
Merged
1 task
@FabijanC
Copy link
Contributor Author

starknet-rs has added SN_SEPOLIA to the list of chain IDs:
xJonathanLEI/starknet-rs#574

I'll assign myself

@FabijanC FabijanC self-assigned this Mar 27, 2024
@FabijanC FabijanC mentioned this issue Mar 27, 2024
Merged
10 tasks
@tkumor3 tkumor3 mentioned this issue Mar 27, 2024
Closed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in starknet-devnet-rs Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FabijanC FabijanC

Labels
bug Something isn't working enhancement New feature or request
Projects
starknet-devnet-rs
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Sepolia chain ID 0xSpaceShard/starknet-devnet-rs
1 participant
@FabijanC