Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument types in fr_raw_generic.cpp seem to be rejected by gmp #25

Closed
0xturboblitz opened this issue Apr 4, 2024 · 3 comments
Closed

Comments

@0xturboblitz
Copy link

Hi
Thanks for making this, we just switched on iOS and it's so fast!
On an iPhone 15 I'm getting 0.5s witness gen for a 450k constraints circuit.

I was able to build smoothly on iOS but when doing make android I'm getting this type of errors:
/Users/turboblitz/code/my-code/zkpassport/proof-of-passport/app/witnesscalc/build/fr_raw_generic.cpp:13:22: error: no matching function for call to '__gmpn_add_n'
...
/Users/turboblitz/code/my-code/zkpassport/witnesscalc/depends/gmp/package_android_arm64/include/gmp.h:1474:26: note: candidate function not viable: no known conversion from 'uint64_t *' (aka 'unsigned long *') to 'mp_ptr' (aka 'unsigned long long *') for 1st argument __GMP_DECLSPEC mp_limb_t mpn_add_n (mp_ptr, mp_srcptr, mp_srcptr, mp_size_t);

I don't know anything about c++ but it looks like gmp does not like the types of the arguments passed by fr_raw_generic.cpp

Am I doing something wrong? Also, I'm running macOS.

@OBrezhniev
Copy link
Member

Hi @0xturboblitz! Please check if #26 fixes your build.

@olomix
Copy link
Collaborator

olomix commented Apr 10, 2024

fixed in #26

@olomix olomix closed this as completed Apr 10, 2024
@0xturboblitz
Copy link
Author

Hi
Thanks so much! This fixed my problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants