You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I ran a deploy script without the US_DRY_RUN=true option, but also without the --broadcast, which gave a simulation of the transactions. However it did create a deployment json file, even though no contracts were actually deployed. If I wanted to go ahead and make a deployment, I'd need to delete some json files before going ahead.
This seems like an in-between step between dry-run and actual execution. Some questions:
Should this "simulation" be the actual dry run? I.e. Remove the US_DRY_RUN flag and just rely on whether the broadcast flag is present?
Regardless whether we keep the US_DRY_RUN flag, is it possible to detect the absence of the --broadcast flag and not output the deployments .json file?
If you're busy but have an opinion, I/we could make the change.
The text was updated successfully, but these errors were encountered:
That's something that had been bothering me from the start, but sadly is currently not possible. The scripts are unable to detect whether --broadcast is enabled or whether it's just a "dry-run" from foundry's scripting perspective. I would also rather get rid of the US_DRY_RUN parameter. I had opened an issue foundry-rs/foundry#2900, but I think my point didn't come across very well. It seems like someone else just commented that they are in need of the same feature though.
To revert to the previous 'deploy-latest.json', you can delete the most recent 'deploy-{timestamp}.json' and restore the second most recent version.
Hey @0xPhaze ! Good stuff!
I ran a deploy script without the
US_DRY_RUN=true
option, but also without the--broadcast
, which gave a simulation of the transactions. However it did create a deploymentjson
file, even though no contracts were actually deployed. If I wanted to go ahead and make a deployment, I'd need to delete some json files before going ahead.This seems like an in-between step between dry-run and actual execution. Some questions:
US_DRY_RUN
flag and just rely on whether the broadcast flag is present?US_DRY_RUN
flag, is it possible to detect the absence of the--broadcast
flag and not output the deployments .json file?If you're busy but have an opinion, I/we could make the change.
The text was updated successfully, but these errors were encountered: