Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiring #28

Open
kyberkiller opened this issue Mar 2, 2018 · 1 comment
Open

Wiring #28

kyberkiller opened this issue Mar 2, 2018 · 1 comment

Comments

@kyberkiller
Copy link

kyberkiller commented Mar 2, 2018

I don't see any input_pullups in code as assumed (like in constructor?), no idea where to connect the button's other end and encoder's common pin. Adding one or two sentences in readme would be really helpful and add value to your library.

If some general understanding of encoder electrical connections is expected, please add relevant links.

@krukhlis
Copy link

Author has already provided response in the same issue created long ago. Please check
#7:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants