From 3c56bf19ca258499c77905a8a063041b3cf344cd Mon Sep 17 00:00:00 2001
From: 0xJacky <me@jackyu.cn>
Date: Thu, 7 Jul 2022 00:04:57 +0800
Subject: [PATCH] optimized terminal

---
 frontend/src/views/pty/Terminal.vue | 13 ++++++++-----
 frontend/version.json               |  2 +-
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/frontend/src/views/pty/Terminal.vue b/frontend/src/views/pty/Terminal.vue
index 7e1455c9..d77b8b1c 100644
--- a/frontend/src/views/pty/Terminal.vue
+++ b/frontend/src/views/pty/Terminal.vue
@@ -2,7 +2,6 @@
     <a-card :title="$gettext('Terminal')">
         <div class="console" id="terminal"></div>
     </a-card>
-
 </template>
 
 <script>
@@ -34,6 +33,7 @@ export default {
         window.removeEventListener('resize', this.fit)
         clearInterval(this.ping)
         this.ping = null
+        this.term.close()
         this.websocket.close()
     },
     methods: {
@@ -46,13 +46,16 @@ export default {
                 convertEol: true,
                 fontSize: 14,
                 cursorStyle: 'block',
-                scrollback: 30,
+                scrollback: 1000,
+                theme: {
+                    background: 'rgba(3,14,32,0.7)'
+                },
             })
             const fitAddon = new FitAddon()
             term.loadAddon(fitAddon)
             this.fitAddon = fitAddon
             term.open(document.getElementById('terminal'))
-            setTimeout(()=>{
+            setTimeout(() => {
                 fitAddon.fit()
             }, 60)
             window.addEventListener('resize', this.fit)
@@ -71,7 +74,7 @@ export default {
                 that.sendMessage({Type: 1, Data: data})
             })
             term.onResize(data => {
-                that.sendMessage({Type:2, Data:{Cols:data.cols, Rows: data.rows}})
+                that.sendMessage({Type: 2, Data: {Cols: data.cols, Rows: data.rows}})
             })
             this.term = term
         },
@@ -93,6 +96,6 @@ export default {
 
 <style lang="less" scoped>
 .console {
-    min-height: 800px;
+    min-height: calc(100vh - 300px);
 }
 </style>
diff --git a/frontend/version.json b/frontend/version.json
index 511dc10c..aeb1e2a5 100644
--- a/frontend/version.json
+++ b/frontend/version.json
@@ -1 +1 @@
-{"version":"1.4.0","build_id":4,"total_build":60}
\ No newline at end of file
+{"version":"1.4.0","build_id":5,"total_build":61}
\ No newline at end of file