Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Remove/refactor .clone() from the /ol/types folder where needed #1258

Open
wants to merge 1 commit into
base: v6
Choose a base branch
from

Conversation

shawnharmsen
Copy link

@shawnharmsen shawnharmsen commented Apr 24, 2023

fixes: #1204

  • using rustfmt and clippy for formatting and linting

@shawnharmsen
Copy link
Author

shawnharmsen commented Apr 24, 2023

val_config_ip_address test fails on v6 branch as well as here

➜  types git:(v6) cargo test
    Finished test [unoptimized + debuginfo] target(s) in 0.55s
     Running unittests (/Users/term/Desktop/my-github/libra/target/debug/deps/ol_types-3fb17c86fafb9dfe)

running 12 tests
test epoch_timer::test_changeset ... ok
test fixtures::test_block ... ok
test account::test_parse_account_file ... ok
test pay_instruction::parse_file ... ok
test pay_instruction::parse_fixed_recurr_type ... ok
test pay_instruction::parse_pct_balance_end_epoch_type ... ok
test pay_instruction::parse_fixed_recurr_end_epoch_type ... ok
test pay_instruction::parse_pct_change_end_epoch_type ... ok
test pay_instruction::parse_pct_balance_type ... ok
test pay_instruction::parse_pct_change_type ... ok
test pay_instruction::parse_fixed_once_type ... ok
test account::val_config_ip_address ... FAILED

failures:

---- account::val_config_ip_address stdout ----
thread 'account::val_config_ip_address' panicked at 'assertion failed: `(left == right)`
  left: `"012d0400a1230da9052218072029fa0229ff55e1307caf3e32f3f4d0f2cb322cbb5e6d264c1df92e7740e1c06f0800"`,
 right: `"012d0400a1230da90522180720893cc3f3b7f5bc55eb73e2e668520533fbe3938c4658ee70893f69e5944b76160800"`', ol/types/src/account.rs:327:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    account::val_config_ip_address

test result: FAILED. 11 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s

error: test failed, to rerun pass '--lib'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chore] Remove/refactor .clone() from the /ol/types folder where needed
2 participants