Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Refactor .unwrap() with Match in /ol/util folder #1257

Open
wants to merge 2 commits into
base: v6
Choose a base branch
from
Open

[Chore] Refactor .unwrap() with Match in /ol/util folder #1257

wants to merge 2 commits into from

Conversation

shawnharmsen
Copy link

@shawnharmsen shawnharmsen commented Apr 24, 2023 •
edited
Loading

fixes: #1193

  • using cargo check to test
  • using clippy linter

please let me know if there are other steps to test before seeing what ci catches

main questions I've had so far is

  • most efficient way to check if it compiles
  • best way to run tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chore] Refactor .unwrap() with Match in /ol/util folder
1 participant
@shawnharmsen